Skip to content

Fix release workflow needs#290

Merged
eluce2 merged 1 commit into
mainfrom
codex/fix-release-workflow-needs
Jun 17, 2026
Merged

Fix release workflow needs#290
eluce2 merged 1 commit into
mainfrom
codex/fix-release-workflow-needs

Conversation

@eluce2

@eluce2 eluce2 commented Jun 17, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • remove stale cli-smoke release dependency
  • fixes workflow validation failure before jobs start

Test

  • pnpm run ci

Summary by CodeRabbit

  • Chores
    • Updated release workflow job dependencies to ensure proper validation sequencing before publishing releases.

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ef79379

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
proofkit-docs Ready Ready Preview, Comment Jun 17, 2026 9:55pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 11a53443-a7f8-4c13-a627-c659dc63c56f

📥 Commits

Reviewing files that changed from the base of the PR and between 7f7a288 and ef79379.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/release.yml
📝 Walkthrough

Walkthrough

In .github/workflows/release.yml, the release job's needs list is updated by removing cli-smoke as a prerequisite, keeping fmodata-e2e as the sole required job before the Changesets publish step executes.

Changes

Release Workflow Dependency Update

Layer / File(s) Summary
Release job needs list
.github/workflows/release.yml		 cli-smoke is removed from the needs list of the release job; fmodata-e2e remains as the required prerequisite before the Changesets release action runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix release workflow needs' directly addresses the main change: updating the job dependencies in the release workflow by removing the stale cli-smoke job and adding fmodata-e2e, which aligns with the PR's stated objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-release-workflow-needs

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

@proofkit/better-auth

pnpm add https://pkg.pr.new/proofsh/proofkit/@proofkit/better-auth@290

@proofkit/fmdapi

pnpm add https://pkg.pr.new/proofsh/proofkit/@proofkit/fmdapi@290

@proofkit/fmodata

pnpm add https://pkg.pr.new/proofsh/proofkit/@proofkit/fmodata@290

@proofkit/typegen

pnpm add https://pkg.pr.new/proofsh/proofkit/@proofkit/typegen@290

@proofkit/webviewer

pnpm add https://pkg.pr.new/proofsh/proofkit/@proofkit/webviewer@290

commit: ef79379

@eluce2 eluce2 merged commit 4782878 into main Jun 17, 2026
18 checks passed
@eluce2 eluce2 deleted the codex/fix-release-workflow-needs branch June 17, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eluce2